xen0n added a comment.

I've formatted the patch summary for you. Please familiarize yourself with 
Markdown syntax so next time your rendering would look better.

In D136413#3873317 <https://reviews.llvm.org/D136413#3873317>, @tangyouling 
wrote:

> Do we need to add the definition of the `__loongarch64` macro? gcc has that 
> definition (but it is not recommended to use it, just for compatibility with 
> previous code).
> It has been used in some projects before, such as linux kernel, libunwind etc.

For minimum churn and hassle, I'm afraid we have to add it for now. I didn't 
realize [[ 
https://github.com/loongson/LoongArch-Documentation/pull/28#discussion_r917367794
 | it's the equivalent of `__mips64` ]] until too much software has been ported 
with it...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136413/new/

https://reviews.llvm.org/D136413

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to