carlocab added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2136
+ } else {
+ sdk = "macosx";
+ }
----------------
Since we’re already doing a bunch of triple checks above, it probably doesn’t
hurt to check that we really are targeting macOS here.
This may not help with any real use cases, but, in the past, some tests get
broken when LLVM is configured with `-DDEFAULT_SYSROOT`, and this change is
likely to break those tests in the same way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136315/new/
https://reviews.llvm.org/D136315
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
