mgorny added inline comments.

================
Comment at: clang-tools-extra/clangd/CMakeLists.txt:48
 gen_decision_forest(${CMAKE_CURRENT_SOURCE_DIR}/quality/model CompletionModel 
clang::clangd::Example)
+file(GLOB CompletionModel_files 
"${CMAKE_CURRENT_BINARY_DIR}/CompletionModel/CompletionModel*.cpp")
 
----------------
Since the file is included, can't you just pass it via variable (i.e. set with 
`PARENT_SCOPE`)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136283/new/

https://reviews.llvm.org/D136283

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH... Sam James via Phabricator via cfe-commits
    • [... Michał Górny via Phabricator via cfe-commits
    • [... Sam James via Phabricator via cfe-commits
    • [... Nico Weber via Phabricator via cfe-commits
    • [... Arfrever Frehtes Taifersar Arahesis via Phabricator via cfe-commits

Reply via email to