beanz added a comment.

In addition to restoring the test cases that you deleted, I think you should 
also reduce and simplify the test cases you're adding. These new tests are very 
large blobs of IR generated by clang. They include a lot of extra instructions 
that aren't needed to exercise the code you wrote in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135429/new/

https://reviews.llvm.org/D135429

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to