Author: Kazu Hirata Date: 2022-10-15T21:54:13-07:00 New Revision: 08901c8a980d98672d456558fac3b2bee990bf61
URL: https://github.com/llvm/llvm-project/commit/08901c8a980d98672d456558fac3b2bee990bf61 DIFF: https://github.com/llvm/llvm-project/commit/08901c8a980d98672d456558fac3b2bee990bf61.diff LOG: [clang] Use llvm::reverse (NFC) Added: Modified: clang/include/clang/Analysis/Analyses/ThreadSafetyUtil.h clang/lib/AST/Interp/Function.h clang/lib/Driver/ToolChains/Clang.cpp clang/lib/StaticAnalyzer/Core/BugReporter.cpp Removed: ################################################################################ diff --git a/clang/include/clang/Analysis/Analyses/ThreadSafetyUtil.h b/clang/include/clang/Analysis/Analyses/ThreadSafetyUtil.h index 088474b9b2980..7792707e50250 100644 --- a/clang/include/clang/Analysis/Analyses/ThreadSafetyUtil.h +++ b/clang/include/clang/Analysis/Analyses/ThreadSafetyUtil.h @@ -204,11 +204,11 @@ template <class T> class SimpleArray { } llvm::iterator_range<reverse_iterator> reverse() { - return llvm::make_range(rbegin(), rend()); + return llvm::reverse(*this); } llvm::iterator_range<const_reverse_iterator> reverse() const { - return llvm::make_range(rbegin(), rend()); + return llvm::reverse(*this); } private: diff --git a/clang/lib/AST/Interp/Function.h b/clang/lib/AST/Interp/Function.h index 67a4e27b3753f..f73a6d3f3c9ce 100644 --- a/clang/lib/AST/Interp/Function.h +++ b/clang/lib/AST/Interp/Function.h @@ -111,7 +111,7 @@ class Function final { using arg_reverse_iterator = SmallVectorImpl<PrimType>::const_reverse_iterator; llvm::iterator_range<arg_reverse_iterator> args_reverse() const { - return llvm::make_range(ParamTypes.rbegin(), ParamTypes.rend()); + return llvm::reverse(ParamTypes); } /// Returns a specific scope. diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index faac52de70649..2dfd815c5c93e 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -1657,7 +1657,7 @@ void RenderARMABI(const Driver &D, const llvm::Triple &Triple, void AddUnalignedAccessWarning(ArgStringList &CmdArgs) { auto StrictAlignIter = - std::find_if(CmdArgs.rbegin(), CmdArgs.rend(), [](StringRef Arg) { + llvm::find_if(llvm::reverse(CmdArgs), [](StringRef Arg) { return Arg == "+strict-align" || Arg == "-strict-align"; }); if (StrictAlignIter != CmdArgs.rend() && diff --git a/clang/lib/StaticAnalyzer/Core/BugReporter.cpp b/clang/lib/StaticAnalyzer/Core/BugReporter.cpp index 4d6b82e63f6a4..6996f590a7cf6 100644 --- a/clang/lib/StaticAnalyzer/Core/BugReporter.cpp +++ b/clang/lib/StaticAnalyzer/Core/BugReporter.cpp @@ -3097,9 +3097,8 @@ void BugReporter::FlushReport(BugReportEquivClass& EQ) { if (getAnalyzerOptions().ShouldDisplayNotesAsEvents) { // For path diagnostic consumers that don't support extra notes, // we may optionally convert those to path notes. - for (auto I = report->getNotes().rbegin(), - E = report->getNotes().rend(); I != E; ++I) { - PathDiagnosticNotePiece *Piece = I->get(); + for (const auto &I : llvm::reverse(report->getNotes())) { + PathDiagnosticNotePiece *Piece = I.get(); auto ConvertedPiece = std::make_shared<PathDiagnosticEventPiece>( Piece->getLocation(), Piece->getString()); for (const auto &R: Piece->getRanges()) @@ -3108,9 +3107,8 @@ void BugReporter::FlushReport(BugReportEquivClass& EQ) { Pieces.push_front(std::move(ConvertedPiece)); } } else { - for (auto I = report->getNotes().rbegin(), - E = report->getNotes().rend(); I != E; ++I) - Pieces.push_front(*I); + for (const auto &I : llvm::reverse(report->getNotes())) + Pieces.push_front(I); } for (const auto &I : report->getFixits()) _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
