vsapsai added a comment.

The change looks good to me. And based on the scope of D121685 
<https://reviews.llvm.org/D121685> it should be sufficient. Do you have any 
ideas for testing? If it would require significant testing infrastructure work, 
we can do that separately. But if you have some simple testing ideas in mind, 
that would be worth adding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136019/new/

https://reviews.llvm.org/D136019

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to