paulkirth added inline comments.
================ Comment at: clang/test/Frontend/frame-diags.c:1 +// TODO: This is not really a functional test yet, and needs to be rewritten. +// currently its just a copy of backend-diagnostics.c, and all of the run/test ---------------- probinson wrote: > I know this is a draft and has a TODO but: > Something like this could go into cross-project-tests, but an llvm change > should have an llvm test, not a clang test. You could use clang to generate > IR once, and keep instructions for regenerating the IR as comments in the > test file. We do this a lot for debug info tests. I totally agree. I planned to follow the existing examples for ‘frame-larger-than’ with tests in llvm on behavior etc., and checks for the diagnostics being plumbed correctly in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
