kadircet added a comment.

i also would rather not have the workaround solely for an editor (we usually 
try to address these on editor/plugin side). i am also worried about the 
understanding of that inferred line afterwards (e.g. what if editor thinks that 
line doesn't have a trailing `\n` and send edits with that view of the world, 
or somehow attributes the `\n` to the next line instead)

moreover, this won't fix the issue for existing clangd's (and until the next 
release). so i'd rather get it fixed on the client side (and if we can't, i 
guess editors that can't have delta changes reliably just send full text as 
changes).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135508/new/

https://reviews.llvm.org/D135508

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to