steven_wu accepted this revision. steven_wu added a comment. LGTM.
`RemoveDecl` does become more expensive but I don't have better solution. I am also wondering if as follow up we should add an option to `VerifyDiagnosticConsumer` to be location aware (so the diagnostics from a file is emitted in order) to prevent more problem like this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135118/new/ https://reviews.llvm.org/D135118 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
