jpenix-quic marked an inline comment as done. jpenix-quic added a comment. In D130513#3827108 <https://reviews.llvm.org/D130513#3827108>, @jeanPerier wrote:
> The lowering part looks good to me (I only have a minor comment inlined about > a header used in lowering). Thank you @jeanPerier for looking over the lowering portion! Regarding moving the header (I'm replying to the comment here since the inline one now opens in a separate revision/window as the file is gone), I moved it to Lower/EnvironmentDefault.h as lowering is where I use it (as you mentioned). Please let me know if this needs further changes! Just to confirm/as a final check, @awarzynski does the driver portion look good to you? Similarly, @klausler does the runtime portion look good to you? I believe I addressed the comments you both left previously, but I want to make sure that I addressed things appropriately. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
