tahonermann closed this revision. tahonermann marked 2 inline comments as done. tahonermann added a comment.
Pushed, but I forgot to add the `Differential Revision` tag to the commit, so closing manually. The changes landed as commit 4247cdb568eca4c31b14d91105fe5ee140225036 <https://reviews.llvm.org/rG4247cdb568eca4c31b14d91105fe5ee140225036>. ================ Comment at: clang/lib/AST/ASTDumper.cpp:240 + // the innerworkings of dyn_cast() do assert that to be the case! Alas, + // strange and unfortunate things do occasionally occur that lead to folk + // like yourself, dear reader, running a debugger and feeling extraordinarily ---------------- erichkeane wrote: > This gets a little overly coy for our comments... Aw, I was having fun writing that comment! No problem, I'll sprinkle some professional polishing salts on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133499/new/ https://reviews.llvm.org/D133499 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
