cor3ntin added inline comments.
================ Comment at: clang/lib/Parse/ParseExprCXX.cpp:1265 + if (Intro.hasLambdaCapture()) + P.Diag(StaticLoc, diag::err_static_lambda_captures); +} ---------------- aaron.ballman wrote: > aaron.ballman wrote: > > royjacobson wrote: > > > cor3ntin wrote: > > > > We might want to add a note showing where the capture list is. > > > I added a note, but the captures list is always just before the static > > > specifier, so I'm not sure how useful it is. WDYT? > > > > > FWIW, I'm not sure the note adds a whole lot of value. @cor3ntin, do you > > have a code example in mind where you think the note would be clarifying? > I think we should remove the note here -- we can add a note back when we run > into a use case where it would be enlightening. I was just thinking that with sufficient attributes, templates, require clauses and parameters, the lambda might be cluttered enough that a note would not hurt. I'm not strongly attached to it though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
