ckandeler added a comment.
In D134728#3822653 <https://reviews.llvm.org/D134728#3822653>, @sammccall wrote:
> It doesn't scale very well though: we're limited to 30 modifiers in total,
> this patch brings us up to 16, if we followed this class.constructor
> precedent for function.operator, class.constructor.copy enum.scoped etc we
> could end up exhausting this.
In light of this (and assuming it really has to be this way), would it make
sense to introduce a generic modifier that changes its meaning depending on the
main highlighting kind? It would have the drawback of not being
self-documenting, but with the given constraints might just be a pragmatic
solution:
enum class HighlightingModifier {
// ...
// Class -> Constructor/Destructor
// Document new uses here
Generic,
// ...
};
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134728/new/
https://reviews.llvm.org/D134728
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
