DavidSpickett added inline comments.
================
Comment at: clang/lib/Support/CMakeLists.txt:21
+ # libLLVM-*.so, to be used by clang-tblgen. This is so clang-tblgen doesn't
+ # accidentally link against libLLVMSupport twice (once statically and once
via
+ # libLLVM-*.so).
----------------
Without this change, is it the case that it will always link against
libLLVMSupport twice with the DYLIB conifg?
"accidentally" sounds like you could stumble into it but from what I see, it's
always been doing this and once your other change lands, it would always result
in an error.
```
This is so clang-tblgen doesn't link against libLLVMSupport twice (once
statically and once via libLLVM-*.so).
```
================
Comment at: clang/lib/Support/CMakeLists.txt:26
+ DISABLE_LLVM_LINK_LLVM_DYLIB
+ ${clangSupport_sources})
+endif()
----------------
Can you detail which targets link to/include what and how the problem happens?
I'm trying to understand why we can't just use `DISABLE_LLVM_LINK_LLVM_DYLIB`
on its own here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134637/new/
https://reviews.llvm.org/D134637
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
