[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

[Vitaly Buka via Phabricator via cfe-commits]

vitalybuka added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:1767
       MarshallingInfoEnum<CodeGenOpts<"SanitizeAddressDtor">, "Global">;
 defm sanitize_memory_param_retval
     : BoolFOption<"sanitize-memory-param-retval",
----------------
you need to update SanitizerArgs::MsanParamRetval

SanitizerArgs.cpp:1187
```
if (!MsanParamRetval)
    CmdArgs.push_back("-fno-sanitize-memory-param-retval");
```

without that option.td is no-op


Then D134683 works with and without your patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134669/new/

https://reviews.llvm.org/D134669

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits