ahatanak added a comment.
In D86049#3806898 <https://reviews.llvm.org/D86049#3806898>, @plotfi wrote:
> 1. Do we change the existing visibility behavior of objc methods? Yes / No
I don't think we want to change the existing visibility behavior of non-direct
objc methods. Is there a use reason or use case for making them visible outside
the linkage unit?
> 2. If we leave hidden as the default do we change the behavior for
> objc_direct? Yes / No
I think direct methods shouldn't be hidden by default (i.e., they should get
the default visibility). But it's not clear to me whether we should make that
change right away as I've heard concerns from people internally. I think I need
more time to understand what exactly their concerns are.
> 3. If we leave objc_direct as hidden by default do we expand the existing
> objc_direct attr to have the enum as you said so
> `__attribute__((objc_direct("visible")))` or do we add a new attr as I have
> done so far?
I wasn't sure why it wasn't possible to use the existing
`__attribute__((visibility("default")))` attribute. Is it not possible to make
only the direct methods get the default visibility?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86049/new/
https://reviews.llvm.org/D86049
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
