srj added a comment.

This change has broken x86-32 builds, at least on Linux.

  
/usr/local/google/home/srj/GitHub/llvm-project/16/llvm/include/llvm/ADT/PointerIntPair.h:136:25:
 error: static assertion failed: PointerIntPair with integer size too large for 
pointer
    136 |   static_assert(IntBits <= PtrTraits::NumLowBitsAvailable,
        |                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  
/usr/local/google/home/srj/GitHub/llvm-project/16/llvm/include/llvm/ADT/PointerIntPair.h:136:25:
 note: the comparison reduces to ‘(3 <= 2)’
  
/usr/local/google/home/srj/GitHub/llvm-project/16/llvm/include/llvm/ADT/PointerIntPair.h:151:42:
 warning: left shift count >= width of type [-Wshift-count-overflow]
    151 |     ShiftedIntMask = (uintptr_t)(IntMask << IntShift)
        |                                 ~~~~~~~~~^~~~~~~~~~~~
  
/usr/local/google/home/srj/GitHub/llvm-project/16/llvm/include/llvm/ADT/PointerIntPair.h:151:42:
 error: right operand of shift expression ‘(7 << 4294967295)’ is greater than 
or equal to the precision 32 of the left operand [-fpermissive]
  
/usr/local/google/home/srj/GitHub/llvm-project/16/llvm/include/llvm/ADT/PointerIntPair.h:138:8:
 error: enumerator value for ‘ShiftedIntMask’ is not an integer constant
    138 |   enum MaskAndShiftConstants : uintptr_t {

Please fix or revert immediately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134224/new/

https://reviews.llvm.org/D134224

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to