kwk added inline comments.
================ Comment at: clang-tools-extra/unittests/clang-tidy/MatchersTest.cpp:2 +#include "utils/Matchers.h" +#include "../../clang/unittests/ASTMatchers/ASTMatchersTest.h" + ---------------- njames93 wrote: > @kwk I seem to recall you saying in another patch that this include will > break standalone builds, would stripping the leading `../../` work? > @kwk I seem to recall you saying in another patch that this include will > break standalone builds, @njames93 that's correct. But I don't recall the patch ID :/ > would stripping the leading `../../` work? I don't know if the file is found then but it would make standalone builds certainly easier. I'm not sure if I calculate correctly but given: `clang-tools-extra/unittests/clang-tidy/MatchersTest.cpp` then `../../` means `clang-tools-extra/`, no? If so, that directory doesn't contain a `clang` directory here. It seems as if the `../../` is relative to some other directory but not this file. Or am I too tired to get it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133801/new/ https://reviews.llvm.org/D133801 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
