paulkirth accepted this revision.
paulkirth added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:540
}
-
template <> void addChild(NamespaceInfo *I, EnumInfo &&R) {
----------------
brettw wrote:
> paulkirth wrote:
> > nit: can we avoid unrelated changes to whitespace here and elsewhere in
> > the patch?
> I did this on purpose. There were 8 variants of AddChild and I added two
> more. It became difficult to find the right one so I grouped them with
> comments for each group. This may be difficult to see in the side-by-side but
> it's much nicer in an editor.
That's reasonable. Opening the full context, I see what you're going for.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134371/new/
https://reviews.llvm.org/D134371
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
