Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land.
lgtm ================ Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:129 + // TODO: Track these as `FileEntryRef` to simplify the equality check. + auto A = ScanInstance.getFileManager().getFile(Deps.ClangModuleMapFile); + auto B = ScanInstance.getFileManager().getFile(ModuleMapFile); ---------------- This is loop invariant and can be pulled out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134248/new/ https://reviews.llvm.org/D134248 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
