erichkeane added a comment.

I think this is on the right track, but would like to see more work done on 
that fixme before we commit (or at least better understand what is causing 
this).  I'm afraid of what else can get us into that situation besides the 
export-decl.



================
Comment at: clang/lib/Sema/SemaDecl.cpp:367
+        // with this method returning a non-null ParsedType?
+        if (isa<ExportDecl>(CurContext))
+          return nullptr;
----------------
Hmm... this scares me quite a bit, I don't really know what other fallout 
results from this, or other code that would hit here.

We should probably spend more time making sure we understand this better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53847/new/

https://reviews.llvm.org/D53847

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to