python3kgae marked an inline comment as done. python3kgae added a comment. In D130131#3720552 <https://reviews.llvm.org/D130131#3720552>, @beanz wrote:
> Now that I'm seeing the code in D131370 <https://reviews.llvm.org/D131370>, I > don't know that this is the right way to do things. > > I think using address spaces like this is odd. Address spaces aren't really > intended for use differentiating high level access types, but rather memory > regions and properties of that memory. I feel like the use of address spaces > in this change and in D131370 <https://reviews.llvm.org/D131370> just makes > it more complicated and gets in the way. > > In DXIL, since we don't really have raw memory load and stores, none of these > address spaces mean anything. It is probably just cleaner to not use address > spaces in the CodeGen here either. Removed address space. Also removed nested HLSLBuffer and namespace inside HLSLBuffer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/ https://reviews.llvm.org/D130131 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
