ab added inline comments. Herald added a subscriber: StephenFan. Herald added a project: All.
================ Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:52 + AArch64::AEK_RDM | AArch64::AEK_RCPC | AArch64::AEK_DOTPROD | + AArch64::AEK_SM4 | AArch64::AEK_SHA3 | AArch64::AEK_BF16 | + AArch64::AEK_SHA2 | AArch64::AEK_AES | AArch64::AEK_I8MM)) ---------------- stuij wrote: > SjoerdMeijer wrote: > > just double checking (because I can't remember): BF16 is a mandatory > > extension? > for 8.2 it isn't, for 8.6 it is Belated question: what's the rationale for replacing `AEK_CRYPTO` with SM4+SHA3+SHA2(+AES)? I'm not aware of the required crypto bits changing, but maybe I missed something. There's a related question around how we should deal with crypto here in the first place (remove FK, remove the crypto exts?), but that seems orthogonal to v8.6a+ vs. v8.5a- implying different crypto extensions. For context, this comes up in D134351 where specifying `V8_6A` would enable SM4, which we don't support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
