NoQ added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:538
+                               CallExpr::const_arg_range Args) {
+    for (const auto &[Param, Arg] : llvm::zip(FD->parameters(), Args)) {
+      if (!Param->getType()->isReferenceType())
----------------
IIRC there are a few cases where parameters and arguments don't zip together 
nicely (cf. the hacks we needed to do in 
`CXXMemberOperatorCall::getAdjustedParameterIndex()`, 
`CXXMemberOperatorCall::::getASTArgumentIndex()`). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131067/new/

https://reviews.llvm.org/D131067

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D131067: [analyz... Artem Dergachev via Phabricator via cfe-commits

Reply via email to