mizvekov added inline comments.

================
Comment at: clang/include/clang/AST/Type.h:4601
+    QualType QT = getUnderlyingType();
+    return IsUnqual ? QT.getTypeofUnqualType() : QT;
+  }
----------------
shafik wrote:
> It is interesting that you do `getTypeofUnqualType` in the constructor and 
> then you have to do it again when desuguring. Is this tested in the tests?
The constructor takes the canonical type, while this preserves the unmodified 
type (which can be accessed through getUnderlyingType).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134286/new/

https://reviews.llvm.org/D134286

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to