ChuanqiXu accepted this revision. ChuanqiXu added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Serialization/ModuleManager.cpp:284-286 for (ModuleIterator victim = First; victim != Last; ++victim) { Modules.erase(victim->File); } ---------------- minor: we can remove the `{` here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134249/new/ https://reviews.llvm.org/D134249 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits