benlangmuir added inline comments.
================ Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:194 + const FileEntry *CurrentModMap = + PP.getHeaderSearchInfo().getModuleMap().getModuleMapFileForUniquing( + CurrentModule); ---------------- I think this should move inside the `if` below for `needsModules`. We are checking the result of `getModuleMapFileForUniquing` for `nullptr` in ModuleDepCollector.cpp -- should we be doing the same here? I find it hard to guess when it might be null, but there's no asserts that it won't be anywhere that I can find. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134222/new/ https://reviews.llvm.org/D134222 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
