erichkeane added inline comments.
================ Comment at: clang/lib/AST/Interp/Boolean.h:50 explicit operator unsigned() const { return V; } + explicit operator int8_t() const { return V; } ---------------- tbaeder wrote: > aaron.ballman wrote: > > At some point, do we want to rename this (and int) to use uint32_t/int32_t? > I can do that as a follow-up commit if you want. Please do, while we don't currently compile on any platforms with non-32 bit int/unsigned, if we ever tried to this would fail with multiple definitions somewhere. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133934/new/ https://reviews.llvm.org/D133934 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits