yusuke-kadowaki added inline comments.
================ Comment at: clang/include/clang/Format/Format.h:428 + + bool operator==(const TrailingCommentsAlignmentStyle &R) const { + return Kind == R.Kind && OverEmptyLines == R.OverEmptyLines; ---------------- MyDeveloperDay wrote: > yusuke-kadowaki wrote: > > MyDeveloperDay wrote: > > > yusuke-kadowaki wrote: > > > > > I don't understand the need for state as a struct could have multiple > > > > > options (as enums) each enum should have a state that means "Leave" > > > > > > > > @MyDeveloperDay > > > > Without having state, how can this be implemented? > > > bool Enabled = (Kind != FormatStyle::TCAS_Leave) > > Oh ok so I think we are on the same page. > do you need this? Yes. Without this it does not compile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org/D132131 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits