shafik added inline comments.
================ Comment at: clang/include/clang/Parse/Parser.h:2283 case DeclSpecContext::DSC_top_level: + case DeclSpecContext::DSC_offsetof: return true; ---------------- Why `true` for this case? What does this allow that we want? Do we test it? ================ Comment at: clang/lib/Parse/ParseExpr.cpp:2583 + TypeResult Ty = + ParseTypeName(/*Range*/ nullptr, DeclaratorContext::OffsetOf); if (Ty.isInvalid()) { ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits