zhouyizhou added a comment. In D133066#3780900 <https://reviews.llvm.org/D133066#3780900>, @aaron.ballman wrote:
> In D133066#3768091 <https://reviews.llvm.org/D133066#3768091>, @zhouyizhou > wrote: > >> In D133066#3767146 <https://reviews.llvm.org/D133066#3767146>, >> @aaron.ballman wrote: >> >>> In D133066#3765503 <https://reviews.llvm.org/D133066#3765503>, @zhouyizhou >>> wrote: >>> >>>> In D133066#3764384 <https://reviews.llvm.org/D133066#3764384>, >>>> @aaron.ballman wrote: >>>> >>>>> The existing comment is correct according to my copy of the C++11 >>>>> standard, but the standard has changed since C++11 and those words no >>>>> longer appear in http://eel.is/c++draft/dcl.init.ref#5. Some more >>>>> investigation is needed, but I suspect the correct action to take here is >>>>> to update the comment based on the current standards wording or to see if >>>>> there's a bug because the code does not match the comment. >>>> >>>> thank Aaron for review my patch, >>>> I am a passionate beginner, >>> >>> Welcome to the community, we're glad to have you here! >> >> Thank Aaron for your encouragement and guidance! Hope I can be some >> beneficial to the community. >> >>>> this is a very good learning experience for me ;-) I am looking forward >>>> to seeing the final change. >>> >>> Happy to help, but to be clear on the next steps: are you planning to do >>> the investigation work, or were you hoping someone else would do it? >> >> As an amateur, this is a difficult job for me, but I can't help taking a try. > > For what it's worth, it's not easy for experts either. :-D Thanks again for your patience, and sorry for the late feedback, I think I will spend 3 more weeks to work out and submit my tentative work. >> Following your guidance, I found the original C++11 document on the >> internet: >> https://raw.githubusercontent.com/yjlintw/book-Coding-Developer/master/%E6%A0%87%E5%87%86%E6%96%87%E6%A1%A3/ISO%20IEC%2014882%202011%20(C%2B%2B11).pdf >> >> (the non ASCII code in URL means this document is maintained by a Chinese >> like me). >> And those words are there! > > Yup, that matches my copy of C++11; btw, you can find a late-stage working > draft on the committee website at: > https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/n3242.pdf Yes, and I also find those words in above document and the example that follows is almost the same except a minor difference. >> I am eager to do some investigation work in the elementary stage, but I >> believe the final work should be done by someone else. >> >> Thanks again for your enthusiasm and your patience! > > My pleasure! > > For the moment, I don't think any changes are needed here regarding the > comment. Thanks again for your guidance. OK. and I use "git log -p cba72b1f620fd" the study the original submit which add those words. This is a fruitful and happy journey for me ;-) Cheers Zhouyi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133066/new/ https://reviews.llvm.org/D133066 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
