mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land.
This LGTM, but one question about the test. Thanks! ================ Comment at: clang/test/CodeGenCXX/dllstorage-hidden.cpp:3 + +// RUN: %clang_cc1 -triple x86_64-windows-msvc -fms-extensions -emit-llvm -fvisibility-inlines-hidden -o - %s | FileCheck %s --check-prefix=MSVC +// RUN: %clang_cc1 -triple x86_64-windows-gnu -fms-extensions -emit-llvm -fvisibility-inlines-hidden -o - %s | FileCheck %s --check-prefix=GNU ---------------- What parts of this test requires `-fms-extensions`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133180/new/ https://reviews.llvm.org/D133180 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
