Mordante added subscribers: ldionne, Mordante.
Mordante added inline comments.
================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:377
+ CFLAGS: "-fcrash-diagnostics-dir=crash_diagnostics_dir"
+ CXXFLAGS: "-fcrash-diagnostics-dir=crash_diagnostics_dir"
LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}"
----------------
I actually think this change would be nice for libc++ in general. I've has
several assertion failures in the bootstrapping CI. Especially with the
symbolizer available the crash reports become a lot better.
I'm not convinced the way you used the `CXXFLAGS` in the CMakeLists.txt is the
best way, maybe @ldionne has a better suggestion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127695/new/
https://reviews.llvm.org/D127695
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
