mizvekov added a comment. Just a first glance at the patch, will try to do a more comprehensive review later.
================ Comment at: clang/lib/Sema/SemaConcept.cpp:823 + // + // Using the pattern is suffice because the partial ordering rules guarantee + // the template paramaters are equivalent. ---------------- ================ Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1838 - QualType Replacement = Arg.getAsType(); ---------------- I think this change could be masking a bug. The arguments to an instantiation should always be canonical. We could implement one day instantiation with non-canonical args, but this would not be the only change required to get this to work. And regardless it should be done in separate patch with proper test cases :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
