gribozavr2 added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:220 void UseEqualsDefaultCheck::registerMatchers(MatchFinder *Finder) { - // Skip unions since constructors with empty bodies behave differently - // in comparison with structs/classes. + // Skip union-like classes since constructors with empty bodies behave + // differently in comparison with structs/classes. ---------------- ================ Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:225 + anyOf(isUnion(), + has(fieldDecl(isImplicit(), hasType(cxxRecordDecl(isUnion())))))); ---------------- Why is "isImplicit" needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132713/new/ https://reviews.llvm.org/D132713 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits