erichkeane added inline comments.
================ Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:860 + } else if (const auto *ND = Unexpanded[I].first.get<const NamedDecl *>(); + isa<VarDecl>(ND)) { + // Function parameter pack or init-capture pack. ---------------- This pattern with the init + condition is a little awkward here... any reason to not just use the cast around the 'ND" and just use the VD in the use below? or is there a good reason to split it up like this? Same with the above case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits