aaron.ballman accepted this revision.
aaron.ballman added a comment.
Thanks, this looks like it cleans up some needlessly chatty diagnostics! Just
had a question that you can fix when landing if you agree, otherwise LGTM as
well.
================
Comment at: clang/lib/Parse/ParseDecl.cpp:4651
if (Tok.isNot(tok::l_brace)) {
+ DS.SetTypeSpecError();
// Has no name and is not a definition.
----------------
Shouldn't this be lifted out of the `if` statement into the parent one where we
issue the error diagnostic?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132695/new/
https://reviews.llvm.org/D132695
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
