ChuanqiXu added a comment. In D131388#3748769 <https://reviews.llvm.org/D131388#3748769>, @ruoso wrote:
> I just noticed that the document was implying that Header Units were separate > from the Standard C++ Modules, but they are an integral part of the language > in the specification of modules. The contrast that we do is between "Named > Modules" and "Header Units". I did some edits to help convey that. Yeah, I know header units are part of modules. Technically, the "header units" are special synthesized units . And the entities in header units part of the global module. And global module have no name. So here is the term `Named Modules`. I didn't mention this since I feel this bring some language details to the users but I feel like this is not helpful for users. For me, it is simpler and workable to think "header units" are special headers and treat "named modules" and "modules" interchangeably. But given you are doing a lot of modules documentation work, I'll follow your suggestion to make the terms consistency. (BTW, it is a little bit weird to me since "header units" should be "units" literally but we call it modules) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
