brianosman added a comment.

I agree that  the front-end error is preferable. In addition to front-end vs. 
back-end distinction being important -- it's also ignorable (if someone wants 
to do that).
Is the goal to also make __has_cpp_attribute(clang::musttail) resolve to 0? I 
think that's the ideal outcome - it lets users rely on documented ("standard") 
behavior to make decisions about which attributes to use. As it stands, I have 
to write my code like this:

  #if __has_cpp_attribute(clang::musttail) && !defined(__EMSCRIPTEN__)
    ...

That's brittle, and easy to overlook or forget to update if/when the WASM 
engines and LLVM code-gen do support musttail in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131990/new/

https://reviews.llvm.org/D131990

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to