LuoYuanke added inline comments.
================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:2472
+ case BuiltinType::BFloat16:
+ mangleArtificialTagType(TTK_Struct, "__bf16", {"__clang"});
----------------
This looks irrelative to the patch.
================
Comment at: clang/test/CodeGen/X86/avx512bf16-builtins.c:7
-float test_mm_cvtsbh_ss(__bfloat16 A) {
- // CHECK-LABEL: @test_mm_cvtsbh_ss
- // CHECK: zext i16 %{{.*}} to i32
- // CHECK: shl i32 %{{.*}}, 16
- // CHECK: bitcast i32 %{{.*}} to float
+float test_mm_cvtsbh_ss(__bf16 A) {
+ // CHECK: fpext bfloat %{{.*}} to float
----------------
Add a test case for `__bfloat16` to test compatibility?
================
Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:4904
ClangBuiltin<"__builtin_ia32_cvtne2ps2bf16_128">,
- Intrinsic<[llvm_v8i16_ty], [llvm_v4f32_ty, llvm_v4f32_ty],
+ Intrinsic<[llvm_v8bf16_ty], [llvm_v4f32_ty, llvm_v4f32_ty],
[IntrNoMem]>;
----------------
Probably need to upgrade the old intrinsics to new version for IR compatibility
or we can keep IR unchanged and just generate bitcast from bfloat16 to i16.
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:2180
+ if (!Subtarget.useSoftFloat() && Subtarget.hasBF16()) {
+ addRegisterClass(MVT::bf16, &X86::FR16XRegClass);
+ addRegisterClass(MVT::v8bf16, &X86::VR128XRegClass);
----------------
Not sure about this. Does it make bf16 legal type?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132329/new/
https://reviews.llvm.org/D132329
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
