MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land.
================ Comment at: flang/test/Driver/pic-flags.f90:69 +! CHECK-ROPI: "-mrelocation-model" "ropi" +! CHECK-ROPI-NOT: -pic + ---------------- I'd use `! CHECK-ROPI-NOT: "-pic` otherwise there is a risk that the pattern matches a temporary file named `*-pic*`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131533/new/ https://reviews.llvm.org/D131533 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
