yaxunl added a comment. In D132248#3736295 <https://reviews.llvm.org/D132248#3736295>, @tra wrote:
> I'm OK with that. > > @yaxunl -- what are your thoughts on whether this approach would work for > HIP? On one hand HIP already has a lot of features that the new driver is > intended to provide, so AMD may have no pressure to change to something else. > On the other hand, long term it would make sense to unify the driver pipeline > across the different offloading mechanisms we have now. I am OK as long as it works for HIP and does not break the old driver. ================ Comment at: clang/test/Driver/cuda-bindings.cu:154 +// +// RUN: %clang -### -target powerpc64le-ibm-linux-gnu --offload-new-driver -ccc-print-bindings \ +// RUN: --offload-arch=sm_70 --offload-arch=sm_52 --offload-device-only -c %s 2>&1 \ ---------------- can you add similar tests for HIP? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132248/new/ https://reviews.llvm.org/D132248 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
