sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM, thanks @CarolineConcatto. Please land D132137 
<https://reviews.llvm.org/D132137> before landing this one to avoid regressions 
on combines that previously worked on svget/svset.



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9382
     SVETypeFlags TF(Builtin->TypeModifier);
     auto VTy = cast<llvm::VectorType>(getSVEType(TF));
+    Value *V0 = Builder.CreateExtractVector(VTy, Ops[0],
----------------
nit: If you cast this to `ScalableVectorType`, you can use 
`VTy->getMinNumElements()` below on line 9385


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131547/new/

https://reviews.llvm.org/D131547

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to