rymiel added a comment. Note for reviewing: The criteria for reaching this misformat are extremely specific, requiring a single-character type or a type of a type consisting of all-uppercase letter, which are poor style on their own. I am also unsure how often this all-uppercase macro-like attribute syntax is relied upon
I chose to simply add the keyword `noexcept` to the negative check for symbols, since, as far as I am aware, `noexcept` is the only legal specifier which can follow a constructor However, I am unsure what the usual course of action is for version/language specific things, since I only use clang-format for modern C++, but it appears to be capable of a whole lot more than that. I ask this because directly after my added line, there's mention of Objective-C, and technically `noexcept` itself wasn't always in C++. Should there be extra checks for these. There could also possibly be a TokenAnnotatorTest checking for `TT_FunctionAnnotationRParen`, but there wasn't an existing one similar to it, so I was unsure if I should add one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132189/new/ https://reviews.llvm.org/D132189 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
