ssquare08 added a comment. In D129694#3708297 <https://reviews.llvm.org/D129694#3708297>, @jhuber6 wrote:
> In D129694#3708214 <https://reviews.llvm.org/D129694#3708214>, @ssquare08 > wrote: > >> If that's the preference I can make changes as suggested. You mentioned CUDA >> and HIP mangle the declaration directly. To me it looks like they mangle it >> on host and device separately. Is that not correct? If so, can you point me >> to the source you are referring to? > > You're right, they mangle them separately like in > https://godbolt.org/z/r6hG4brqx, this is most likely because they already had > separate "device side" names. For OpenMP we currently just use the same name > for the variable on the host and device side like in > https://godbolt.org/z/eaGo9qsW3 where we just use the same kernel names. > Thinking again, I'm still wondering if there's any utility in keeping the > names separate. Correct me if I'm wrong, but the host-side variable should be > able to remain internal so this mangled device name shouldn't show up in the > final executable. In that case the only benefit is slightly nicer IR, which > I'm not super concerned with. Yes, the host-side variable should be able to remain internal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129694/new/ https://reviews.llvm.org/D129694 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
