ilya-biryukov added a comment.

Could you please add a test with a compilation database that models the 
blocking behavior, attempts cancellation and ensures no diagnostics are 
produced?
I also suggest adding a callback similar to `Callbacks.onFailedAST`, which 
could be used for testing this behavior.
The test should also check that subsequent updates and reads get resolved 
properly.
We don't have an actual implementation for the client code that relies on this 
in-tree, but the unit test will help to ensure we don't break this contract.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131569/new/

https://reviews.llvm.org/D131569

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to