shafik added a comment.

In D131307#3709644 <https://reviews.llvm.org/D131307#3709644>, @erichkeane 
wrote:

> 



> That IS Undefined Behavior, but I think was unintended by this patch.  The 
> intent of this patch (and its parent) was to diagnose this UB during 
> `constexpr` evaluation.  HOWEVER, this patch seems to have extended it to 
> non-`constexpr` constant evaluation.  So while that _IS_ undefined behavior, 
> I don't think it should be covered by this error (likely a normal 'warning' 
> is fine here, but not this diagnostic).  Hopefully @shafik can correct this 
> when he starts again today.

That was not totally intended. I am working on some changes to narrow down the 
scope of the diagnostic and hopefully that will reduce the fallout.

Although Erich is correct, that is undefined behavior and should be eventually 
be fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131307/new/

https://reviews.llvm.org/D131307

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to