MaskRay accepted this revision. MaskRay added inline comments.
================ Comment at: llvm/lib/Support/Triple.cpp:1938 + return false; + + if (getVendor() != UnknownVendor) ---------------- The prevailing style doesn't add a blank line for every `if` statement. ================ Comment at: llvm/lib/Support/Triple.cpp:1980 +} // HLSL triple environment orders are relied on in the front end static_assert(Triple::Vertex - Triple::Pixel == 1, ---------------- Add a blank line before the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits