kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks lgtm!
================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:2187
+TEST(CompletionTest, FixItForMembersUsing) {
+ const Annotations Code(R"cpp(
----------------
no need for this test in clangd, as it's testing the same thing you've in clang
lit test (and clang is the righteous place to test this behavior)
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1101
(R.Availability == CXAvailability_Available ||
R.Availability == CXAvailability_Deprecated));
Result.ShadowDecl = Using;
----------------
can you also fix the constructor call here?
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1276
(R.Availability == CXAvailability_Available ||
R.Availability == CXAvailability_Deprecated));
Result.ShadowDecl = Using;
----------------
you can just pass `std::move(R.FixIts)` as the next argument in this
constructor call instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131088/new/
https://reviews.llvm.org/D131088
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
