beanz added inline comments.
================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.h:64
CodeGenModule &CGM;
uint32_t ResourceCounters[static_cast<uint32_t>(
hlsl::ResourceClass::NumClasses)] = {0};
----------------
Anastasia wrote:
> This is not part of this change but any reason why it is a protected member
> and not private?
I wrote that code, and had a vague idea of a use case in my head where we might
provide subclasses of the HLSLRuntime, but in retrospect that is unlikely
anytime soon, so we could safely make that `private.`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130951/new/
https://reviews.llvm.org/D130951
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
